Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent adding identity transforms to the document #1493

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Oletus
Copy link
Contributor

@Oletus Oletus commented Jan 23, 2024

What kind of change does this PR introduce?

This makes the resulting PDF files smaller. It's cumbersome to filter out all commands that could result in identity transforms in code that's using PDFKit, so it makes sense to have the check in the transform() function.

Checklist:

  • Unit Tests
  • Documentation N/A
  • Update CHANGELOG.md
  • Ready to be merged

This change is sponsored by Higharc.

This makes the resulting PDF files smaller. It's cumbersome to filter out all commands that could result in identity transforms in code that's using PDFKit, so it makes sense to have the check in the transform() function.
@blikblum blikblum merged commit a655194 into foliojs:master Jan 23, 2024
4 checks passed
@Oletus Oletus deleted the optimize-identity-transforms branch January 26, 2024 10:17
@Oletus
Copy link
Contributor Author

Oletus commented Jan 26, 2024

Thanks for the quick review! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants